Codecov Report

❌ Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.00%. Comparing base (2b4c350) to head (c49c519).

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   90.73%   91.00%   +0.26%     
==========================================
  Files          16       16              
  Lines        2300     2378      +78     
==========================================
+ Hits         2087     2164      +77     
- Misses        213      214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

So I built a draft implementation for Moreau.jl using this branch; it worked really well! Thank you.

A few issues that popped up:

• We need to decide whether to cache data for the backward pass when we solve the forward problem. There doesn't seem to be any way to know if we're being called from a DiffOpt context or not, so I ended up using the presence of the DiffOpt library as a proxy for whether to store backward gradients.
• We support differentiating the quadratic term in the objective, and it seemed to me DiffOpt only supported linear sensitivity of the obj? I wasn't sure.
• Converting from dobj (DiffOpt) to dx (Moreau interface) required us to cache a bunch of data structures like P, x, and q that we otherwise didn't need in the Julia interface.
• We ended up needing to cache the structure of A on the Julia side to dA and db into dconstraint

Overall, I think a bunch of this is just API differences, and probably can't be fixed at this point, but figured it was worth mentioning.